Themes for standalone and web playground#13
Merged
Merged
Conversation
Documents the two-layer CSS variable system, the conversion pipeline from VSCode theme JSON to --vscode-* CSS variables, build-time bundling from OpenVSX, runtime theme installation, and localStorage persistence. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The three-layer chain (--vscode-* → --mt-* → --color-*) had a redundant middle layer. Every --mt-* variable was a pure passthrough to --color-*. - Delete 38 dead variables defined 3× each (114 lines): --mt-ansi-*, --mt-terminal-cursor/selection, --mt-gutter*, --mt-editor-font-*, --mt-selection-workspace — none were consumed anywhere - Eliminate duplicate mappings: focusBorder was aliased as --mt-accent, --mt-gutter-active, and --mt-selection-terminal - Drop testing.iconPassed → success mapping (wrong semantic); hardcode green - Move var(--vscode-*, fallback) chains directly into @theme - Update Dockview overrides and inline style refs to use --color-* Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Build-time: scripts/bundle-themes.mjs downloads VSIX files from OpenVSX, extracts theme JSONs, and converts them to --vscode-* CSS variable maps. 13 bundled themes: Dark+, Light+, 9 GitHub variants, 2 Dracula variants. Runtime: users can search and install additional themes from OpenVSX directly in the browser. VSIX extraction uses fflate (~8KB). Installed themes persist in localStorage. Core library in lib/src/lib/themes/: - convert.ts: CONSUMED_VSCODE_KEYS filter + dots-to-hyphens conversion - apply.ts: sets --vscode-* vars on body + manages vscode-light class - store.ts: bundled + installed registry with localStorage persistence - openvsx.ts: search API + in-browser VSIX download/extraction Replaces the 5 hardcoded themes in playground-themes.ts. Storybook themes now derive from bundled.json instead of manual color maps. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- AGENTS.md: replace deleted website/src/lib/playground-themes.ts with lib/src/lib/themes/, add theme.md spec entry - theme.md: fix bundle-themes.mjs path (scripts/ -> lib/scripts/), update stale "replaces the current" for deleted PlaygroundTheme file - layout.md: update --mt-* references to --color-* (collapsed in theme refactor), fix var(--mt-surface) -> var(--color-surface)
Deploying mouseterm with
|
| Latest commit: |
156c3e2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c4cb237d.mouseterm.pages.dev |
| Branch Preview URL: | https://feat-theme-embed.mouseterm.pages.dev |
nedtwigg
added a commit
that referenced
this pull request
May 22, 2026
The first security audit (issue #83) caught two real items: 1. workflow-audit.yaml used actions/checkout@v6 instead of a SHA pin. I authored that file and should have followed the same pattern as security-audit.yaml; SHA-pinning to v6.0.2 now, matching the rest of this repo. 2. tend-*.yaml also use @v6-style tag pins (actions/checkout, astral-sh/setup-uv). Those files are owned by the upstream generator, max-sixty/tend, so local SHA-pinning would diverge from generator output and the next nightly regen would revert. Reflecting reality in SECURITY.md: accept tag pins inside tend-*.yaml, require SHA pins everywhere else (including workflow-audit.yaml and security-audit.yaml). The audit's third finding — FAIL IF #13, "workflow-audit has not run in 48 hours" — resolves on its own once the manual trigger completes; no code change needed. The UNVERIFIABLE INFO findings on rulesets/secrets remain by design until an AUDIT_PAT with `Administration: read` is provisioned. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.